Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14D187B64 for ; Thu, 3 Nov 2011 16:01:57 +0000 (UTC) Received: (qmail 94272 invoked by uid 500); 3 Nov 2011 16:01:56 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 94161 invoked by uid 500); 3 Nov 2011 16:01:56 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 94150 invoked by uid 500); 3 Nov 2011 16:01:56 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 94143 invoked by uid 99); 3 Nov 2011 16:01:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 16:01:56 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 16:01:55 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7797C330997 for ; Thu, 3 Nov 2011 16:01:35 +0000 (UTC) Date: Thu, 3 Nov 2011 16:01:35 +0000 (UTC) From: "Chinna Rao Lalam (Updated) (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <250692565.56202.1320336095492.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1075812065.6014.1299011496987.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HIVE-2017) Driver.execute() should maintaining SessionState in case of runtime errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-2017: ----------------------------------- Attachment: HIVE-2017.4.patch > Driver.execute() should maintaining SessionState in case of runtime errors > -------------------------------------------------------------------------- > > Key: HIVE-2017 > URL: https://issues.apache.org/jira/browse/HIVE-2017 > Project: Hive > Issue Type: Bug > Reporter: Ning Zhang > Assignee: Chinna Rao Lalam > Attachments: HIVE-2017.1.patch, HIVE-2017.2.patch, HIVE-2017.3.patch, HIVE-2017.4.patch > > > Here's a snippet from Driver.execute(): > {code} > // TODO: This error messaging is not very informative. Fix that. > errorMessage = "FAILED: Execution Error, return code " + exitVal + " from " > + tsk.getClass().getName(); > SQLState = "08S01"; > console.printError(errorMessage); > if (running.size() != 0) { > taskCleanup(); > } > return 9; > {code} > I simply returned in case of runtime errors without maintaining SessionState. It could cause resource leak mentioned in HIVE-1959. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira