Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EF317091 for ; Wed, 9 Nov 2011 19:44:46 +0000 (UTC) Received: (qmail 91644 invoked by uid 500); 9 Nov 2011 19:44:46 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 91570 invoked by uid 500); 9 Nov 2011 19:44:46 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 91555 invoked by uid 99); 9 Nov 2011 19:44:46 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2011 19:44:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D42FE1C2C13; Wed, 9 Nov 2011 19:44:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2532432985738568601==" MIME-Version: 1.0 Subject: Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues. From: "Kevin Wilfong" To: "Kevin Wilfong" , "Siying Dong" Date: Wed, 09 Nov 2011 19:44:45 -0000 Message-ID: <20111109194445.23694.32114@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/2783/ Cc: "Ning Zhang" , "hive" , "Weiyan Wang" In-Reply-To: <20111109170146.27743.50456@reviews.apache.org> References: <20111109170146.27743.50456@reviews.apache.org> --===============2532432985738568601== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2011-11-09 17:01:46, Ning Zhang wrote: > > trunk/metastore/if/hive_metastore.thrift, line 373 > > > > > > can this function just called rename_partition(). I agree with Ning's comment about the function name, everything else looks = good to me. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3131 ----------------------------------------------------------- On 2011-11-09 09:04:42, Weiyan Wang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2783/ > ----------------------------------------------------------- > = > (Updated 2011-11-09 09:04:42) > = > = > Review request for hive, Siying Dong and Kevin Wilfong. > = > = > Summary > ------- > = > keep the old api alter_partition, and add the new api alter_rename_partit= ion. In the server side, alter_partition calls alter_rename_partition with = part_vals =3D null > = > Run the "ant test". Only load_fs.q fails, but after I revert the patch an= d run "ant clean package; ant test -Dtestcase=3DTestCliDriver -Dqfile=3Dloa= d_fs.q -Dtest.silent=3Dfalse" it still fails. So I think it's not a bug int= roduced by my patch > = > = > This addresses bug HIVE-2562. > https://issues.apache.org/jira/browse/HIVE-2562 > = > = > Diffs > ----- > = > trunk/metastore/if/hive_metastore.thrift 1199598 = > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 = > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 = > trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skele= ton.cpp 1199598 = > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/meta= store/api/ThriftHiveMetastore.java 1199598 = > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetasto= re.php 1199598 = > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastor= e-remote 1199598 = > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastor= e.py 1199598 = > trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= .java 1199598 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= Client.java 1199598 = > = > Diff: https://reviews.apache.org/r/2783/diff > = > = > Testing > ------- > = > = > Thanks, > = > Weiyan > = > --===============2532432985738568601==--