hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2562) HIVE-2247 Changed the Thrift API causing compatibility issues.
Date Wed, 09 Nov 2011 22:01:54 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147327#comment-13147327
] 

jiraposter@reviews.apache.org commented on HIVE-2562:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3141
-----------------------------------------------------------



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/2783/#comment6951>

    can you keep the comments for this method (after reverting the changes to the comments
as well). 



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/2783/#comment6952>

    the comment here is not clear. are you changing the name of new_part with the name specified
by part_vals or you want to change the partition identified by part_vals with the name found
in new_part? 


- Ning


On 2011-11-09 21:38:50, Weiyan Wang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2783/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-09 21:38:50)
bq.  
bq.  
bq.  Review request for hive, Siying Dong and Kevin Wilfong.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  keep the old api alter_partition, and add the new api alter_rename_partition. In the
server side, alter_partition calls alter_rename_partition with part_vals = null
bq.  
bq.  Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean
package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still
fails. So I think it's not a bug introduced by my patch
bq.  
bq.  
bq.  This addresses bug HIVE-2562.
bq.      https://issues.apache.org/jira/browse/HIVE-2562
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/if/hive_metastore.thrift 1199943 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943

bq.    trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1199943 
bq.    trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943

bq.    trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943

bq.    trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943

bq.    trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1199943 
bq.  
bq.  Diff: https://reviews.apache.org/r/2783/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Weiyan
bq.  
bq.


                
> HIVE-2247 Changed the Thrift API causing compatibility issues.
> --------------------------------------------------------------
>
>                 Key: HIVE-2562
>                 URL: https://issues.apache.org/jira/browse/HIVE-2562
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Kevin Wilfong
>            Assignee: Weiyan Wang
>         Attachments: HIVE-2562-1.patch, HIVE-2562.patch
>
>
> HIVE-2247 Added a parameter to alter_partition in the Metastore Thrift API which has
been causing compatibility issues with some scripts.  We would like to change this to have
two methods, one called alter_partition which takes the old parameters, and one called something
else (I'll leave the naming up to you) which has the new parameters.  The implementation of
the old method should just call the new method with null for the new parameter.
> This will fix the compatibility issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message