hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2553) Use hashing instead of list traversal for IN operator for primitive types
Date Tue, 08 Nov 2011 02:40:52 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146047#comment-13146047
] 

jiraposter@reviews.apache.org commented on HIVE-2553:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2733/
-----------------------------------------------------------

(Updated 2011-11-08 02:40:34.549826)


Review request for Ning Zhang.


Changes
-------

Used the fact we have constant OIs, and did other changes. Behaviour of IN, when at least
one of the variables from IN(...) won't have constant OI set for it, will be unchanged. 

For non-primitive types there are only 2 constant OIs currently implemented, they're for LIST
and MAP. When in future additional constant OIs will be implemented, they can also be added
here in similar manner (and if ConstantObjectInspector had getObject() method that will give
back whatever value any constant OI has inside, then there wouldn't be need for switch between
LIST, MAP and anything that may come in future).   


Summary
-------

Introduction of Hashing for IN operator for primitive types


This addresses bug HIVE-2553.
    https://issues.apache.org/jira/browse/HIVE-2553


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1199066 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java 1199066 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/StructTypeInfo.java 1199066


Diff: https://reviews.apache.org/r/2733/diff


Testing
-------

Worked on some sample queries


Thanks,

Robert


                
> Use hashing instead of list traversal for IN operator for primitive types
> -------------------------------------------------------------------------
>
>                 Key: HIVE-2553
>                 URL: https://issues.apache.org/jira/browse/HIVE-2553
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Minor
>         Attachments: HIVE-2553.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message