hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2592) ConstantOI doesn't always propagate to UDAF
Date Thu, 24 Nov 2011 05:07:40 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156536#comment-13156536
] 

Phabricator commented on HIVE-2592:
-----------------------------------

ikabiljo has commented on the revision "HIVE-2592 [jira] ConstantOI doesn't always propagate
to UDAF".

  There must have been a good reason to have TypeInfo/ObjectInspector pair, since it was built.
I am wondering if that reason is still valid.
  If it is, it might be a best solution to add constant OIs to TypeInfo, and then all different
issues around constant OIs would be resolved.
  If there is not a good reason for TypeInfo any more, then it might be best to just remove
it everywhere (and leave them only for backward compatibility for old UDFs that use them,
but create them upon request, without storing them anywhere).

  What do you think?

REVISION DETAIL
  https://reviews.facebook.net/D513

                
> ConstantOI doesn't always propagate to UDAF
> -------------------------------------------
>
>                 Key: HIVE-2592
>                 URL: https://issues.apache.org/jira/browse/HIVE-2592
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>         Attachments: HIVE-2592.D513.1.patch, HIVE-2592.D513.2.patch
>
>
> Depending on the query plan, a UDAF may not actually get a constant OI.  E.g.,
> set hive.map.aggr=false;
> SELECT percentile_approx(cast(substr(src.value,5) AS double), 0.5) FROM src;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message