hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2017) Driver.execute() should maintaining SessionState in case of runtime errors
Date Thu, 03 Nov 2011 16:01:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143263#comment-13143263
] 

jiraposter@reviews.apache.org commented on HIVE-2017:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1609/
-----------------------------------------------------------

(Updated 2011-11-03 16:01:16.713162)


Review request for hive, John Sichi and Ning Zhang.


Changes
-------

Patch becomes stale so rebased


Summary
-------

while processing two parallel tasks if one of the task fails the Driver.taskCleanup() will
call system.exit() this will shutdown the jvm so it is replaced with the logic to stop the
remaining tasks.. Here need to cleanup 2 kinds of tasks one is non-mr tasks and  mr tasks.
For stopping non-mr tasks used the thread.interrupt() because every non-mr task will be executed
as a thread and for mr tasks maintained a variable called jobKillUri's this variable will
track the spawned job kill uri, in taskCleanup() if it is a mr task using this variable kill
the job. 


This addresses bug HIVE-2017.
    https://issues.apache.org/jira/browse/HIVE-2017


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1197183 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1197183 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1197183 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1197183 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java 1197183

  trunk/ql/src/test/queries/clientnegative/alter_exit.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/alter_exit.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1609/diff


Testing
-------

Added test case for this scenario.  Ran existing test cases


Thanks,

chinna


                
> Driver.execute() should maintaining SessionState in case of runtime errors
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2017
>                 URL: https://issues.apache.org/jira/browse/HIVE-2017
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ning Zhang
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2017.1.patch, HIVE-2017.2.patch, HIVE-2017.3.patch, HIVE-2017.4.patch
>
>
> Here's a snippet from Driver.execute():
> {code}
>             // TODO: This error messaging is not very informative. Fix that.
>             errorMessage = "FAILED: Execution Error, return code " + exitVal + " from
"
>                 + tsk.getClass().getName();
>             SQLState = "08S01";
>             console.printError(errorMessage);
>             if (running.size() != 0) {
>               taskCleanup();
>             }
>             return 9;
> {code}
> I simply returned in case of runtime errors without maintaining SessionState. It could
cause resource leak mentioned in HIVE-1959. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message