hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <kevinwilf...@fb.com>
Subject Review Request: Make index table output of create index command if index is table based
Date Tue, 29 Nov 2011 01:56:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2953/
-----------------------------------------------------------

Review request for hive, Yongqiang He and namit jain.


Summary
-------

If an index is table based, when an index is created it creates a table for that index.  We
should log that table as the output of an index creation command.


This addresses bug HIVE-2611.
    https://issues.apache.org/jira/browse/HIVE-2611


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1207723 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1207723 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1207723 
  trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out 1207723 
  trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out 1207723 
  trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out 1207723 
  trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out 1207723 
  trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/alter_index.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auth.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_auto_update.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_1.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_compression.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_creation.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_stale.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out 1207723 
  trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out 1207723 

Diff: https://reviews.apache.org/r/2953/diff


Testing
-------

Verified that the output of a create index command is now the index table.

Ran the unit tests.


Thanks,

Kevin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message