hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiyan Wang" <wei...@fb.com>
Subject Re: Review Request: [HIVE-2562] HIVE-2247 Changed the Thrift API causing compatibility issues.
Date Wed, 09 Nov 2011 21:40:36 GMT


> On 2011-11-09 17:01:46, Ning Zhang wrote:
> > trunk/metastore/if/hive_metastore.thrift, line 373
> > <https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373>
> >
> >     can this function just called rename_partition().
> 
> Kevin Wilfong wrote:
>     I agree with Ning's comment about the function name, everything else looks good to
me.

I am still running all unit tests.


- Weiyan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3131
-----------------------------------------------------------


On 2011-11-09 21:38:50, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 21:38:50)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the
server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean
package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still
fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2562.
>     https://issues.apache.org/jira/browse/HIVE-2562
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943

>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1199943 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943

>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1199943 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message