hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinna...@huawei.com
Subject Re: Review Request: "LOAD DATA INPATH" fails when the table already contains a file of the same name
Date Wed, 09 Nov 2011 16:44:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1610/
-----------------------------------------------------------

(Updated 2011-11-09 16:44:55.708392)


Review request for hive, Carl Steinbach and John Sichi.


Changes
-------

Load rename made it configurable.


Summary
-------

"LOAD DATA INPATH" fails when the table already contains a file of the same name. If any name
confilcts occurs it will rename the file, After file name got changed it is trying to load
with the old name because of this load is failed. Now we have changed the code like, load
with the changed filename for that introduced a map it will maintain the old name and changed
filename as key value pair and while loading need to use this map.


This addresses bug HIVE-1996.
    https://issues.apache.org/jira/browse/HIVE-1996


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1198626 
  trunk/conf/hive-default.xml 1198626 
  trunk/data/conf/hive-site.xml 1198626 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1198626 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1198626 
  trunk/ql/src/test/queries/clientpositive/input47.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/input47.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1610/diff


Testing
-------

Added a test case for this scenario.


Thanks,

chinna


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message