hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <kevinwilf...@fb.com>
Subject Re: Review Request: HIVE-2247 Changed the Thrift API causing compatibility issues.
Date Wed, 09 Nov 2011 09:01:33 GMT


> On 2011-11-09 08:48:57, Kevin Wilfong wrote:
> > I'll review this, but you should add another reviewer, like Siying, who has the
authority to commit to Hive, as I do not.
> 
> Kevin Wilfong wrote:
>     As long as you're modifying fields, you should add hive to the Groups field and HIVE-2247
in the Bugs field.

Sorry, I thought HIVE-2247 was the JIRA this review was for, it should really be HIVE-2562
in the bugs field, that way everything that gets posted here will get posted on the JIRA as
well.  Thanks for making these changes.  


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/#review3125
-----------------------------------------------------------


On 2011-11-09 08:58:03, Weiyan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2783/
> -----------------------------------------------------------
> 
> (Updated 2011-11-09 08:58:03)
> 
> 
> Review request for hive, Siying Dong and Kevin Wilfong.
> 
> 
> Summary
> -------
> 
> keep the old api alter_partition, and add the new api alter_rename_partition. In the
server side, alter_partition calls alter_rename_partition with part_vals = null
> 
> Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean
package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still
fails. So I think it's not a bug introduced by my patch
> 
> 
> This addresses bug HIVE-2247.
>     https://issues.apache.org/jira/browse/HIVE-2247
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598

>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1199598 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598

>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1199598 
> 
> Diff: https://reviews.apache.org/r/2783/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Weiyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message