hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiyan Wang" <wei...@fb.com>
Subject Re: Review Request: HIVE-2247 Changed the Thrift API causing compatibility issues.
Date Wed, 09 Nov 2011 08:58:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 08:58:03.327969)


Review request for hive, Siying Dong and Kevin Wilfong.


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. In the server
side, alter_partition calls alter_rename_partition with part_vals = null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean
package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still
fails. So I think it's not a bug introduced by my patch


This addresses bug HIVE-2247.
    https://issues.apache.org/jira/browse/HIVE-2247


Diffs
-----

  trunk/metastore/if/hive_metastore.thrift 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1199598 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598

  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598


Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message