hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ning Zhang" <nzh...@fb.com>
Subject Re: Review Request: Allow log4j.properties file used by metastore to be configured
Date Mon, 07 Nov 2011 18:23:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2676/#review3078
-----------------------------------------------------------

Ship it!


LGTM

- Ning


On 2011-11-02 20:18:42, Kevin Wilfong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2676/
> -----------------------------------------------------------
> 
> (Updated 2011-11-02 20:18:42)
> 
> 
> Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning Zhang, Paul
Yang, and namit jain.
> 
> 
> Summary
> -------
> 
> The metastore uses the default hive-log4j.properties only if the log4j.configuration
system property hasn't already been set.
> 
> 
> This addresses bug HIVE-2545.
>     https://issues.apache.org/jira/browse/HIVE-2545
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1196155

> 
> Diff: https://reviews.apache.org/r/2676/diff
> 
> 
> Testing
> -------
> 
> Verified that this allows the properties file specified in log4j.configuration is used
if it is specified.
> 
> Verified that the default hive-log4j.properties file is used if log4j.configuration is
not specified.
> 
> Verified if the metastore is started via 
>      ./hive --service metastore
> in the bin directory, the default properties file is used. (I assume this is the use
case the default was added for from looking at the diff for HIVE-2139)
> 
> 
> Thanks,
> 
> Kevin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message