hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2099) GROUP BY rules not applied correctly for select *
Date Tue, 29 Nov 2011 02:13:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159043#comment-13159043
] 

jiraposter@reviews.apache.org commented on HIVE-2099:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2922/#review3550
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/2922/#comment7911>

    Rather than adding special-case code to handle this, wouldn't it be better to make genColListRegex
call genExprNodeDesc (which is what normally detects the error)?  This would avoid extra code,
and would also make this apply to the other regex cases.
    


- John


On 2011-11-23 14:06:54, chinna wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2922/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-23 14:06:54)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Select * case provided group by validation like select columns list is subset or equal
to the group by columns list. If it violates this validation will throw exception.
bq.  
bq.  
bq.  This addresses bug HIVE-2099.
bq.      https://issues.apache.org/jira/browse/HIVE-2099
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1203044 
bq.    trunk/ql/src/test/queries/clientnegative/groupby_select_all.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/groupby_select_all_alias.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/groupby_select_all_join.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/groupby_select_all_subquery.q PRE-CREATION

bq.    trunk/ql/src/test/queries/clientnegative/groupby_select_all_subquery_unionall.q PRE-CREATION

bq.    trunk/ql/src/test/queries/clientpositive/groupby_select_all.q PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/groupby_select_all.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/groupby_select_all_alias.q.out PRE-CREATION

bq.    trunk/ql/src/test/results/clientnegative/groupby_select_all_join.q.out PRE-CREATION

bq.    trunk/ql/src/test/results/clientnegative/groupby_select_all_subquery.q.out PRE-CREATION

bq.    trunk/ql/src/test/results/clientnegative/groupby_select_all_subquery_unionall.q.out
PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/groupby_select_all.q.out PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2922/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All unit tests passed and added new testcases
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  chinna
bq.  
bq.


                
> GROUP BY rules not applied correctly for select *
> -------------------------------------------------
>
>                 Key: HIVE-2099
>                 URL: https://issues.apache.org/jira/browse/HIVE-2099
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0, 0.9.0
>            Reporter: John Sichi
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2099.1.patch, HIVE-2099.patch
>
>
> This fails as expected:
> select foo, bar from pokes group by foo;
> This succeeds, which is incorrect:
> select * from pokes group by foo;
> I verified this as far back as 0.6, so maybe it has always been this way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message