Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 25 Oct 2011 19:24:33 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <997694142.14789.1319570673294.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <735126768.7409.1318963631399.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HIVE-2510) Hive throws Null Pointer Exception
 upon CREATE TABLE <db_name>.<table_name> ....     if the given <db_name>
 doesn't exist
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HIVE-2510?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13135=
349#comment-13135349 ]=20

jiraposter@reviews.apache.org commented on HIVE-2510:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2426/
-----------------------------------------------------------

(Updated 2011-10-25 19:25:02.433521)


Review request for Yongqiang He, Ning Zhang and Kevin Wilfong.


Summary
-------

Now when creating table in specific database, if that database doesn't exis=
t Hive will return an error informing about that, instead of throwing Null =
Pointer Exception. Null Pointer happens during semantic analysis, so it see=
ms reasonable to return an error before the code that would throw null poin=
ter (Warehouse.getDatabasePath()) executes.


This addresses bug HIVE-2510.
    https://issues.apache.org/jira/browse/HIVE-2510


Diffs
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.j=
ava 1187647=20
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1=
187647=20
  trunk/ql/src/test/queries/clientnegative/create_table_failure1.q PRE-CREA=
TION=20
  trunk/ql/src/test/queries/clientnegative/create_table_failure2.q PRE-CREA=
TION=20
  trunk/ql/src/test/queries/clientnegative/create_table_failure3.q PRE-CREA=
TION=20
  trunk/ql/src/test/queries/clientnegative/create_table_failure4.q PRE-CREA=
TION=20
  trunk/ql/src/test/queries/clientpositive/input45.q PRE-CREATION=20
  trunk/ql/src/test/results/clientnegative/create_table_failure1.q.out PRE-=
CREATION=20
  trunk/ql/src/test/results/clientnegative/create_table_failure2.q.out PRE-=
CREATION=20
  trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out PRE-=
CREATION=20
  trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out PRE-=
CREATION=20
  trunk/ql/src/test/results/clientpositive/input45.q.out PRE-CREATION=20

Diff: https://reviews.apache.org/r/2426/diff


Testing
-------

Run some sample queries and it seemed to work.=20


Thanks,

Robert


               =20
> Hive throws Null Pointer Exception upon CREATE TABLE <db_name>.<table_nam=
e> ....     if the given <db_name> doesn't exist
> -------------------------------------------------------------------------=
------------------------------------------------
>
>                 Key: HIVE-2510
>                 URL: https://issues.apache.org/jira/browse/HIVE-2510
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Sur=C3=B3wka
>            Assignee: Robert Sur=C3=B3wka
>            Priority: Trivial
>         Attachments: HIVE-2510.1.patch, HIVE-2510.2.patch, HIVE-2510.3.pa=
tch, HIVE-2510.4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira