Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C124726B for ; Mon, 24 Oct 2011 17:07:52 +0000 (UTC) Received: (qmail 30249 invoked by uid 500); 24 Oct 2011 17:07:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 30213 invoked by uid 500); 24 Oct 2011 17:07:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 30205 invoked by uid 500); 24 Oct 2011 17:07:52 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 30202 invoked by uid 99); 24 Oct 2011 17:07:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2011 17:07:52 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2011 17:07:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 21D85319F65 for ; Mon, 24 Oct 2011 17:05:32 +0000 (UTC) Date: Mon, 24 Oct 2011 17:05:32 +0000 (UTC) From: "Namit Jain (Commented) (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <2143243296.9364.1319475932140.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-123) refactor DDL code (both DDLWork and DDLTask) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134245#comment-13134245 ] Namit Jain commented on HIVE-123: --------------------------------- Thanks for taking this, Ashutosh. Can you write a quick 10 line note on what this patch does ? It will help tremendously in the review. > refactor DDL code (both DDLWork and DDLTask) > -------------------------------------------- > > Key: HIVE-123 > URL: https://issues.apache.org/jira/browse/HIVE-123 > Project: Hive > Issue Type: Bug > Components: Query Processor > Reporter: Namit Jain > Assignee: Ashutosh Chauhan > Labels: cleanup, refactoring > Attachments: hive-123.patch > > > It might be good to break DDLTask into separate tasks. The abstract class DDLWork can have various subclasses: > showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will make them completely independent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira