hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2519) Dynamic partition insert should enforce the order of the partition spec is the same as the one in schema
Date Mon, 24 Oct 2011 05:24:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133835#comment-13133835
] 

jiraposter@reviews.apache.org commented on HIVE-2519:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2541/
-----------------------------------------------------------

(Updated 2011-10-24 05:25:21.441963)


Review request for hive.


Summary
-------

Suppose the table schema is (a string, b string) partitioned by (p1 string, p2 string), a
dynamic partition insert is allowed to:

insert overwrite ... partition (p2="...", p1);

which will create the wrong HDFS directory structure such as /.../p2=.../p1=.... This is contradictory
to the metastore's assumption of the HDFS directory structure.


This addresses bug HIVE-2519.
    https://issues.apache.org/jira/browse/HIVE-2519


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1188024 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1188024 
  trunk/ql/src/test/queries/clientnegative/dyn_part4.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/dyn_part4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/2541/diff


Testing
-------

ant test


Thanks,

Ning


                
> Dynamic partition insert should enforce the order of the partition spec is the same as
the one in schema
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2519
>                 URL: https://issues.apache.org/jira/browse/HIVE-2519
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ning Zhang
>            Assignee: Ning Zhang
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2519.3.patch, HIVE-2519.patch
>
>
> Suppose the table schema is (a string, b string) partitioned by (p1 string, p2 string),
a dynamic partition insert is allowed to:
> insert overwrite ... partition (p2="...", p1);
> which will create the wrong HDFS directory structure such as /.../p2=.../p1=.... This
is contradictory to the metastore's assumption of the HDFS directory structure. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message