hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2510) Hive throws Null Pointer Exception upon CREATE TABLE <db_name>.<table_name> .... if the given <db_name> doesn't exist
Date Tue, 25 Oct 2011 22:24:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135495#comment-13135495
] 

jiraposter@reviews.apache.org commented on HIVE-2510:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2426/
-----------------------------------------------------------

(Updated 2011-10-25 22:24:42.563999)


Review request for Yongqiang He, Ning Zhang and Kevin Wilfong.


Changes
-------

Remove is_database_exist() method from HiveMetaStore, now check whether database exist is
done directly with use of getDatabase().


Summary
-------

Now when creating table in specific database, if that database doesn't exist Hive will return
an error informing about that, instead of throwing Null Pointer Exception. Null Pointer happens
during semantic analysis, so it seems reasonable to return an error before the code that would
throw null pointer (Warehouse.getDatabasePath()) executes.


This addresses bug HIVE-2510.
    https://issues.apache.org/jira/browse/HIVE-2510


Diffs (updated)
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1188369 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1188369 
  trunk/ql/src/test/queries/clientnegative/create_table_failure1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/create_table_failure2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/create_table_failure3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/create_table_failure4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/input45.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/create_table_failure1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/create_table_failure2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/input45.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/2426/diff


Testing
-------

Run some sample queries and it seemed to work. 


Thanks,

Robert


                
> Hive throws Null Pointer Exception upon CREATE TABLE <db_name>.<table_name>
....     if the given <db_name> doesn't exist
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2510
>                 URL: https://issues.apache.org/jira/browse/HIVE-2510
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2510.1.patch, HIVE-2510.2.patch, HIVE-2510.3.patch, HIVE-2510.4.patch,
HIVE-2510.5.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message