hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinna...@huawei.com
Subject Review Request: Hive disallow any use of function in cluster-by clause
Date Thu, 20 Oct 2011 18:04:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2479/
-----------------------------------------------------------

Review request for hive and Ning Zhang.


Summary
-------

SemanticAnalyzer.genReduceSinkPlan() added a function validation check for orderby and sortby
in the same flow clusterby also executing so it is throwing execption for the clusterby also.

Orderby and Sortby wont support the functions so need to add the function validation check.

Now validation check is modified like it should check only for the orderby and sortby.


This addresses bug HIVE-2512.
    https://issues.apache.org/jira/browse/HIVE-2512


Diffs
-----

  trunk/ql/src/test/results/clientnegative/sortby_function.q.out PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1186306 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1186306 
  trunk/ql/src/test/queries/clientnegative/orderby_function.q 1186306 
  trunk/ql/src/test/queries/clientnegative/sortby_function.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/orderby_function.q.out 1186306 

Diff: https://reviews.apache.org/r/2479/diff


Testing
-------

All unit tests passed


Thanks,

chinna


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message