hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request: This patch adds bytearray as a new datatype in Hive.
Date Wed, 05 Oct 2011 18:05:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1586/
-----------------------------------------------------------

(Updated 2011-10-05 18:05:13.442838)


Review request for hive.


Changes
-------

Uploading hive-2380_4.patch which includes updated *.q.out files for udfs whose description
got updated.


Summary
-------

This patch adds bytearray as a new datatype in Hive.


This addresses bug HIVE-2380.
    https://issues.apache.org/jira/browse/HIVE-2380


Diffs (updated)
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConcat.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1179305 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java 1179305

  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToBinary.java PRE-CREATION

  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_from_binary_6.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/invalid_cast_to_binary_6.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table_union.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/binary_table_bincolserde.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/binary_table_colserde.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/load_binary_data.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_from_binary_6.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/invalid_cast_to_binary_6.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table_union.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/binary_table_bincolserde.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/binary_table_colserde.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/load_binary_data.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/show_describe_func_quotes.q.out 1179305 
  trunk/ql/src/test/results/clientpositive/show_functions.q.out 1179305 
  trunk/ql/src/test/results/clientpositive/udf_concat.q.out 1179305 
  trunk/ql/src/test/results/clientpositive/udf_length.q.out 1179305 
  trunk/ql/src/test/results/clientpositive/udf_substr.q.out 1179305 
  trunk/ql/src/test/results/clientpositive/udf_substring.q.out 1179305 
  trunk/ql/src/test/results/compiler/errors/invalid_function_param2.q.out 1179305 
  trunk/serde/if/serde.thrift 1179305 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1179305 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1179305 
  trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java 1179305

  trunk/serde/src/gen/thrift/gen-php/serde/serde_constants.php 1179305 
  trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 1179305 
  trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java 1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBinaryObjectInspector.java
PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryBinary.java PRE-CREATION

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java 1179305

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 1179305

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 1179305

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/BinaryObjectInspector.java
PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBinaryObjectInspector.java
PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
1179305 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableBinaryObjectInspector.java
PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBinaryObjectInspector.java
PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1179305

  trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java 1179305 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java 1179305

  trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
1179305 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java
1179305 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 1179305 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java 1179305

  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java 1179305

  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java 1179305

  trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java
1179305 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
1179305 

Diff: https://reviews.apache.org/r/1586/diff


Testing
-------

Added and updated unit tests.
Added new system tests.


Thanks,

Ashutosh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message