hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2512) After HIVE-2145, Hive disallow any use of function in cluster-by clause
Date Thu, 20 Oct 2011 18:06:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131850#comment-13131850
] 

jiraposter@reviews.apache.org commented on HIVE-2512:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2479/
-----------------------------------------------------------

Review request for hive and Ning Zhang.


Summary
-------

SemanticAnalyzer.genReduceSinkPlan() added a function validation check for orderby and sortby
in the same flow clusterby also executing so it is throwing execption for the clusterby also.

Orderby and Sortby wont support the functions so need to add the function validation check.

Now validation check is modified like it should check only for the orderby and sortby.


This addresses bug HIVE-2512.
    https://issues.apache.org/jira/browse/HIVE-2512


Diffs
-----

  trunk/ql/src/test/results/clientnegative/sortby_function.q.out PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1186306 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1186306 
  trunk/ql/src/test/queries/clientnegative/orderby_function.q 1186306 
  trunk/ql/src/test/queries/clientnegative/sortby_function.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/orderby_function.q.out 1186306 

Diff: https://reviews.apache.org/r/2479/diff


Testing
-------

All unit tests passed


Thanks,

chinna


                
> After HIVE-2145, Hive disallow any use of function in cluster-by clause
> -----------------------------------------------------------------------
>
>                 Key: HIVE-2512
>                 URL: https://issues.apache.org/jira/browse/HIVE-2512
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ning Zhang
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2512.patch
>
>
> After HIVE-2145, the following query returns a semantic analysis error: 
> FROM src SELECT * cluster by rand();
> FAILED: Error in semantic analysis: functions are not supported in order by
> Looking back at HIVE-2145, it's clear that the patch is more restrictive than necessary.

> Chinna, are you able to work on it? Please let me know if you don't have cycles to do
it now. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message