hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations
Date Thu, 27 Oct 2011 17:38:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137318#comment-13137318
] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------

(Updated 2011-10-27 17:38:58.120670)


Review request for hive and Paul Yang.


Changes
-------

I fixed an issue that was causing altering views to fail.

I ran all the test queries and they succeeded.


Summary
-------

I added a whitelist configuration variable, whose value should be a comma separated list of
hosts.  A set of strings is created based on this list and the host name in a location given
to a create/alter table/partition command to the HiveMetastore is compared to the values in
that set.  If the list is nonempty, the table being altered/created or containing the partition
is not external/non-native, and the location has an explicit host, the command is failed if
the host is not in that set, otherwise the command continues as normal.


This addresses bug HIVE-2502.
    https://issues.apache.org/jira/browse/HIVE-2502


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1189406 
  trunk/conf/hive-default.xml 1189406 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1189406

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1189406 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1189406 

Diff: https://reviews.apache.org/r/2371/diff


Testing
-------

I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:

Issuing the command with a location with a host that is not in the whitelist fails.
Issuing the command with a location with a host in the whitelist does not fail.


Thanks,

Kevin


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition
to verify that the location is acceptable.  The whitelist should be empty by default, and
should be configurable.  The check should default to pass if there is no host in the location,
or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message