Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76A29704E for ; Fri, 2 Sep 2011 17:01:35 +0000 (UTC) Received: (qmail 44697 invoked by uid 500); 2 Sep 2011 17:01:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 44653 invoked by uid 500); 2 Sep 2011 17:01:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 44643 invoked by uid 500); 2 Sep 2011 17:01:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 44640 invoked by uid 99); 2 Sep 2011 17:01:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 17:01:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 17:01:31 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 451FC3C717 for ; Fri, 2 Sep 2011 17:01:10 +0000 (UTC) Date: Fri, 2 Sep 2011 17:01:10 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <2049857359.11243.1314982870279.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <952271014.18554.1314381813312.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2415) disallow partition column names when doing replace columns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096131#comment-13096131 ] Ashutosh Chauhan commented on HIVE-2415: ---------------------------------------- @Ning, I understand that this patch is not introducing any more calls to the metastore but moves them from execution time to compile time. What I am suggesting is insteading of moving those checks from DDLTask to parser, move them to HiveMetaStore. That way they will still be in compile time only but with only one network call to metastore. > disallow partition column names when doing replace columns > ---------------------------------------------------------- > > Key: HIVE-2415 > URL: https://issues.apache.org/jira/browse/HIVE-2415 > Project: Hive > Issue Type: Bug > Reporter: He Yongqiang > Assignee: He Yongqiang > Attachments: HIVE-2415.1.patch > > > alter table replace columns allows to add a column with the same name as partition column, which introduced inconsistency. > We should disallow this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira