Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 150359993 for ; Fri, 23 Sep 2011 21:10:20 +0000 (UTC) Received: (qmail 31378 invoked by uid 500); 23 Sep 2011 21:10:19 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 31331 invoked by uid 500); 23 Sep 2011 21:10:19 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 31319 invoked by uid 99); 23 Sep 2011 21:10:19 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2011 21:10:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 818321C2266; Fri, 23 Sep 2011 21:10:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7138875955180614810==" MIME-Version: 1.0 Subject: Re: Review Request: move lock retry logic into ZooKeeperHiveLockManager From: "Yongqiang He" To: "Ning Zhang" Date: Fri, 23 Sep 2011 21:10:26 -0000 Message-ID: <20110923211026.4435.23796@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1950/ Cc: "Yongqiang He" ,"hive" In-Reply-To: <20110919055109.17351.47742@reviews.apache.org> References: <20110919055109.17351.47742@reviews.apache.org> --===============7138875955180614810== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1950/ ----------------------------------------------------------- (Updated 2011-09-23 21:10:26.466632) Review request for hive and Ning Zhang. Changes ------- update comment in hive-default.xml Summary ------- move lock retry logic into ZooKeeperHiveLockManager This addresses bug HIVE-2450. https://issues.apache.org/jira/browse/HIVE-2450 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1171255 = trunk/conf/hive-default.xml 1171255 = trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1171255 = trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java 1= 171255 = trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHi= veLockManager.java 1171255 = Diff: https://reviews.apache.org/r/1950/diff Testing ------- will run tests locally Thanks, Yongqiang --===============7138875955180614810==--