Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C6ED753D for ; Thu, 22 Sep 2011 18:26:13 +0000 (UTC) Received: (qmail 36909 invoked by uid 500); 22 Sep 2011 18:26:13 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 36885 invoked by uid 500); 22 Sep 2011 18:26:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 36866 invoked by uid 99); 22 Sep 2011 18:26:12 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2011 18:26:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D84541C025E; Thu, 22 Sep 2011 18:26:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7546689677832842150==" MIME-Version: 1.0 Subject: Re: Review Request: Clean up the scratch.dir (tmp/hive-root) while restarting Hive server. From: chinnarao@huawei.com To: "John Sichi" , chinnarao@huawei.com, "hive" , "M IS" Date: Thu, 22 Sep 2011 18:26:19 -0000 Message-ID: <20110922182619.17350.17057@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1481/ In-Reply-To: <20110921133022.17350.12341@reviews.apache.org> References: <20110921133022.17350.12341@reviews.apache.org> --===============7546689677832842150== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1481/ ----------------------------------------------------------- (Updated 2011-09-22 18:26:19.812602) Review request for hive. Changes ------- In testcases server startup is removed and added unit tests for cleanUpScra= tchDir(). Summary ------- Now queries leaves the map outputs under scratch.dir after execution. If th= e hive server is stopped we need not keep the stopped server's map oputputs= . So whle starting the server we can clear the scratch.dir. This can help i= n improved disk usage. Implemented a cleanup method in HiveServer and it will trigger based on the= property value "hive.start.cleanup.scrachdir" This addresses bug HIVE-2181. https://issues.apache.org/jira/browse/HIVE-2181 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/common/ServerUtils.java PRE-= CREATION = trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1174277 = trunk/conf/hive-default.xml 1174277 = trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java 117= 4277 = trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java= 1174277 = Diff: https://reviews.apache.org/r/1481/diff Testing ------- Added test case for this scenario. Thanks, chinna --===============7546689677832842150==--