Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29D9C860C for ; Wed, 7 Sep 2011 08:24:23 +0000 (UTC) Received: (qmail 23129 invoked by uid 500); 7 Sep 2011 08:24:23 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 21848 invoked by uid 500); 7 Sep 2011 08:24:16 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 21815 invoked by uid 99); 7 Sep 2011 08:24:11 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2011 08:24:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A7EBE1C1312; Wed, 7 Sep 2011 08:24:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1580416464245177723==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2412. Update Eclipse configuration to include Mockito dependency From: "Amareshwari Sriramadasu" To: "Amareshwari Sriramadasu" Date: Wed, 07 Sep 2011 08:24:17 -0000 Message-ID: <20110907082417.2073.64334@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1665/ Cc: "hive" ,"Carl Steinbach" In-Reply-To: <20110826021254.17843.88036@reviews.apache.org> References: <20110826021254.17843.88036@reviews.apache.org> --===============1580416464245177723== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1665/#review1782 ----------------------------------------------------------- Ship it! +1 - Amareshwari On 2011-08-26 02:12:54, Carl Steinbach wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1665/ > ----------------------------------------------------------- > = > (Updated 2011-08-26 02:12:54) > = > = > Review request for hive and Amareshwari Sriramadasu. > = > = > Summary > ------- > = > This patch does two things: > = > * Fixes the eclipse project generation code by including mockito > on the classpath > = > * Updates the HiveCli launch configuration template so that the > metastore JAR is no longer on the classpath, and also moves the > hive-exec JAR to the end of the classpath. This was done in > order to give preference on the classpath to local changes, > which up to this point have been obscured by hive-exec and > hive-metastore JAR files located in the build directory. Note > that in order to run the HiveCLI launchtemplate you now need to > have the Datanucleus Eclipse Plugin installed, and > must "enhance" the project. > = > = > This addresses bug HIVE-2412. > https://issues.apache.org/jira/browse/HIVE-2412 > = > = > Diffs > ----- > = > eclipse-templates/.classpath b59b343 = > eclipse-templates/HiveCLI.launchtemplate 0fa86cb = > = > Diff: https://reviews.apache.org/r/1665/diff > = > = > Testing > ------- > = > Verified that project generation and import works. Also verified that Hiv= eCLI launch template works. > = > = > Thanks, > = > Carl > = > --===============1580416464245177723==--