Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 634167F0E for ; Tue, 6 Sep 2011 22:01:30 +0000 (UTC) Received: (qmail 68404 invoked by uid 500); 6 Sep 2011 22:01:30 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 68130 invoked by uid 500); 6 Sep 2011 22:01:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 68115 invoked by uid 99); 6 Sep 2011 22:01:29 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 22:01:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 204FE1C1504; Tue, 6 Sep 2011 22:01:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2076554754995133404==" MIME-Version: 1.0 Subject: Re: Review Request: get_privilege does not get user level privilege and should return emptylist instead of null From: "Yongqiang He" To: "Ning Zhang" Date: Tue, 06 Sep 2011 22:01:35 -0000 Message-ID: <20110906220135.2073.2291@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1646/ Cc: "Yongqiang He" ,"hive" In-Reply-To: <20110824222339.18088.45660@reviews.apache.org> References: <20110824222339.18088.45660@reviews.apache.org> --===============2076554754995133404== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1646/#review1774 ----------------------------------------------------------- trunk/ql/src/test/queries/clientpositive/authorization_7.q yes. what we want to do is to test the global privilege. The first comm= and is to grant a global privilege, and after that do test with that. = - Yongqiang On 2011-08-24 22:23:39, Yongqiang He wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1646/ > ----------------------------------------------------------- > = > (Updated 2011-08-24 22:23:39) > = > = > Review request for hive and Ning Zhang. > = > = > Summary > ------- > = > get_privilege does not get user level privilege and should return emptyli= st instead of null > = > = > This addresses bug HIVE-2405. > https://issues.apache.org/jira/browse/HIVE-2405 > = > = > Diffs > ----- > = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= .java 1161232 = > trunk/ql/src/test/queries/clientpositive/authorization_7.q PRE-CREATION = > trunk/ql/src/test/results/clientpositive/authorization_7.q.out PRE-CREA= TION = > = > Diff: https://reviews.apache.org/r/1646/diff > = > = > Testing > ------- > = > = > Thanks, > = > Yongqiang > = > --===============2076554754995133404==--