Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 79DFD8B87 for ; Fri, 2 Sep 2011 01:41:29 +0000 (UTC) Received: (qmail 4287 invoked by uid 500); 2 Sep 2011 01:41:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 4232 invoked by uid 500); 2 Sep 2011 01:41:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 4219 invoked by uid 99); 2 Sep 2011 01:41:28 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 01:41:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 975CE1C004A; Fri, 2 Sep 2011 01:41:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6527404165932622581==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2304. Support PreparedStatement.setObject From: "Carl Steinbach" To: "hive" , "Carl Steinbach" Date: Fri, 02 Sep 2011 01:41:33 -0000 Message-ID: <20110902014133.11731.55625@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1700/ In-Reply-To: <20110902013533.25495.27427@reviews.apache.org> References: <20110902013533.25495.27427@reviews.apache.org> --===============6527404165932622581== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1700/#review1731 ----------------------------------------------------------- jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java Please Add a negative testcase that exercises this exception. jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java Please add a new testcase or add to an existing testcase instead of mod= ifying a pre-existing testcase. You have provided test coverage for Prepare= dStatement.setObject() at the expense of removing test coverage for Prepare= dStatement.setBoolean()/setInt(),etc. - Carl On 2011-09-02 01:35:33, Carl Steinbach wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1700/ > ----------------------------------------------------------- > = > (Updated 2011-09-02 01:35:33) > = > = > Review request for hive. > = > = > Summary > ------- > = > Review for HIVE-2304 (Ido Hadanny) > = > = > This addresses bug HIVE-2304. > https://issues.apache.org/jira/browse/HIVE-2304 > = > = > Diffs > ----- > = > jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 67= 9792c = > jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 = > = > Diff: https://reviews.apache.org/r/1700/diff > = > = > Testing > ------- > = > = > Thanks, > = > Carl > = > --===============6527404165932622581==--