hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-198) Parse errors report incorrectly.
Date Tue, 13 Sep 2011 01:37:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103261#comment-13103261
] 

jiraposter@reviews.apache.org commented on HIVE-198:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1818/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Modified the message to include the actual token it fails on (When available).
It should make it easier to grok the actual problem from the error.


This addresses bug HIVE-198.
    https://issues.apache.org/jira/browse/HIVE-198


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1164307 
  trunk/ql/src/test/results/clientnegative/column_rename3.q.out 1164307 
  trunk/ql/src/test/results/clientnegative/invalid_select_expression.q.out 1164307 
  trunk/ql/src/test/results/clientnegative/invalid_tbl_name.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/garbage.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out 1164307 

Diff: https://reviews.apache.org/r/1818/diff


Testing
-------

ant test -Dtestcase=TestParseNegative


Thanks,

avivey



> Parse errors report incorrectly.
> --------------------------------
>
>                 Key: HIVE-198
>                 URL: https://issues.apache.org/jira/browse/HIVE-198
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: S. Alex Smith
>            Assignee: Aviv Eyal
>              Labels: parse
>         Attachments: HIVE-198.2.patch.txt, PraseErrorMessage.patch
>
>
> The following two queries fail:
> CREATE TABLE output_table(userid, bigint);
> CREATE TABLE output_table(userid bigint, age int, sex string, location string);
> each giving the error message "FAILED: Parse Error: line 1:16 mismatched input 'TABLE'
expecting KW_TEMPORARY"
> Although one might not catch it from the error message, the problem with the first is
that there is a comma between "userid" and "bigint", and the problem with the second is that
"location" is a reserved keyword.  Reported errors should more accurately describe the nature
of the error, such as "no type given for column 'userid'" or "'location' is not a valid column
name".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message