hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From " (JIRA)" <>
Subject [jira] [Commented] (HIVE-2461) Add method to PerfLogger to perform cleanup/final steps.
Date Thu, 22 Sep 2011 23:55:29 GMT

] commented on HIVE-2461:

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-09-22 23:54:37.554390)

Review request for hive, Yongqiang He and Ning Zhang.

Summary (updated)

I added a method called finishPerfLogger, which is called at the end of the run method in
Driver to allow PerfLogger subclasses to perform any cleanup tasks or logging that requires
all the perf stats to have been calculated.  It takes as parameters a Log, to be consistent
with the other methods in PerfLogger, as well as the QueryPlan from Driver in order to allow
information such as the query ID to be logged.

I should note that finishPerfLogger is not guaranteed to run.  This was my intention.

This addresses bug HIVE-2461.


  trunk/ql/src/java/org/apache/hadoop/hive/ql/ 1173881 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/log/ 1173881 



I created a subclass of PerfLogger which implemented the finishPerfLogger method, and verified
it was successfully called and executed.

I also ran some of the unit tests to verify nothing was broken.



> Add method to PerfLogger to perform cleanup/final steps.
> --------------------------------------------------------
>                 Key: HIVE-2461
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2461.1.patch.txt
> I think a method added to PerfLogger to perform cleanup/final steps would be very useful.
 For example, it could be used to close any database connections created as part of a PerfLogger
subclass, or to perform logging that requires all perf values to first be calculated.

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message