hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-2457. Files in Avro-backed Hive tables do not have a ".avro" extension
Date Wed, 21 Sep 2011 00:26:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1989/#review1982
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/1989/#comment4468>

    Please add this configuration property to HiveConf and hive-default.xml



trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java
<https://reviews.apache.org/r/1989/#comment4479>

    In addition to the unit test it would also be nice to test this via TestCliDriver.
    
    It should be possible to verify this from the CLI by doing something like this:
    
    
    -- Set the filename suffix property. Then create a new table and stream
    -- data into it. Then use the dfs cat command to dump the contents of
    -- the raw files in the warehouse to stdout
    hive> dfs -cat ${hiveconf:hive.metastore.warehouse.dir}/<tablename>/*.avro;


- Carl


On 2011-09-20 22:28:53, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1989/
> -----------------------------------------------------------
> 
> (Updated 2011-09-20 22:28:53)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review for HIVE-2457
> 
> 
> This addresses bug HIVE-2457.
>     https://issues.apache.org/jira/browse/HIVE-2457
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1173340 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1173340 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java 1173340 
>   trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1989/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message