hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ning Zhang" <nzh...@fb.com>
Subject Review Request: JDBCStatsAggregator DELETE STATEMENT should escape _ and %
Date Mon, 19 Sep 2011 17:28:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1957/
-----------------------------------------------------------

Review request for hive.


Summary
-------

JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate
results. The delete is using LIKE operator, so it needs to escape '_' and '%'.


This addresses bug HIVE-2456.
    https://issues.apache.org/jira/browse/HIVE-2456


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 1172720

  trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java 1172720 

Diff: https://reviews.apache.org/r/1957/diff


Testing
-------

Running unit tests. 


Thanks,

Ning


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message