hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <>
Subject Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset
Date Tue, 13 Sep 2011 20:03:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-09-13 20:03:48.343559)

Review request for hive and Carl Steinbach.


Changes per review comments. 
Added a JDBC test.

The CLI behaviour does look like a but. The JDBC and ODBC client are working fine, but CLI
is not printing the header. I will go ahead and log a separate Jira for that. 


The Hive server currently has the framework to process the Cli commands like 'set'. But it
returns an empty schema definition for these resultsets. The patch here is to add a getSchema()
to the CommandResponse interface. The SetProcessor is modified to build a schema object which
is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.

This addresses bug HIVE-2398.

Diffs (updated)

  jdbc/src/test/org/apache/hadoop/hive/jdbc/ e744d11 
  ql/src/java/org/apache/hadoop/hive/ql/processors/ 4f7f472 
  ql/src/java/org/apache/hadoop/hive/ql/processors/ 9ca5ca4 
  service/src/java/org/apache/hadoop/hive/service/ 95f322a 



Tested with ODBC program to execute the set command. Ran Hive unit tests.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message