hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From av...@fb.com
Subject Re: Review Request: HIVE-198: Parse errors report incorrectly
Date Tue, 13 Sep 2011 01:39:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1818/
-----------------------------------------------------------

(Updated 2011-09-13 01:39:58.571166)


Review request for hive.


Summary (updated)
-------

Modified the ParseException message to include the actual token it fails on (When available).
It should make it easier to grok the actual problem from the error.


This addresses bug HIVE-198.
    https://issues.apache.org/jira/browse/HIVE-198


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1164307 
  trunk/ql/src/test/results/clientnegative/column_rename3.q.out 1164307 
  trunk/ql/src/test/results/clientnegative/invalid_select_expression.q.out 1164307 
  trunk/ql/src/test/results/clientnegative/invalid_tbl_name.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/garbage.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1164307 
  trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out 1164307 

Diff: https://reviews.apache.org/r/1818/diff


Testing
-------

ant test -Dtestcase=TestParseNegative


Thanks,

avivey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message