hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2445) The PerfLogger should log the full name of hooks, not just the simple name.
Date Wed, 14 Sep 2011 16:55:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104663#comment-13104663
] 

jiraposter@reviews.apache.org commented on HIVE-2445:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1882/
-----------------------------------------------------------

Review request for hive and Ning Zhang.


Summary
-------

I change the method called when logging pre, failure, and post hooks to the PerfLogger to
getName instead of getSimpleName.


This addresses bug HIVE-2445.
    https://issues.apache.org/jira/browse/HIVE-2445


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268 

Diff: https://reviews.apache.org/r/1882/diff


Testing
-------

Ran the unit test queries, and verified the intended change in the logs.


Thanks,

Kevin



> The PerfLogger should log the full name of hooks, not just the simple name.
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-2445
>                 URL: https://issues.apache.org/jira/browse/HIVE-2445
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>
> Sometimes the simple name of a hook is not enough to identify it, so the PerfLogger should
log the full name instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message