hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2178) Log related Check style Comments fixes
Date Wed, 21 Sep 2011 13:37:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109498#comment-13109498
] 

jiraposter@reviews.apache.org commented on HIVE-2178:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1978/
-----------------------------------------------------------

(Updated 2011-09-21 13:36:23.594198)


Review request for hive, Carl Steinbach and John Sichi.


Changes
-------

Thrift generated code changes are excluded from the patch. Thrift generated code changes i
will follow up.


Summary
-------

Fixed Log related Check style Comments like including root exception and adding messages.


This addresses bug HIVE-2178.
    https://issues.apache.org/jira/browse/HIVE-2178


Diffs (updated)
-----

  trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 1173507 
  trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java 1173507 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1173507 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1173507 
  trunk/ql/src/test/results/clientnegative/describe_xpath1.q.out 1173507 
  trunk/ql/src/test/results/clientnegative/describe_xpath2.q.out 1173507 
  trunk/ql/src/test/results/clientnegative/describe_xpath3.q.out 1173507 
  trunk/ql/src/test/results/clientnegative/describe_xpath4.q.out 1173507 
  trunk/ql/src/test/results/clientnegative/lockneg4.q.out 1173507 
  trunk/ql/src/test/results/clientnegative/lockneg5.q.out 1173507 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/SimpleCharStream.java 1173507

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java 1173507


Diff: https://reviews.apache.org/r/1978/diff


Testing
-------

Ran all unit tests


Thanks,

chinna



> Log related Check style Comments fixes
> --------------------------------------
>
>                 Key: HIVE-2178
>                 URL: https://issues.apache.org/jira/browse/HIVE-2178
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2
(i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2178.1.patch, HIVE-2178.2.patch, HIVE-2178.3.patch, HIVE-2178.patch
>
>
> Fix Log related Check style Comments

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message