hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2304) Support PreparedStatement.setObject
Date Fri, 02 Sep 2011 01:42:14 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095713#comment-13095713
] 

jiraposter@reviews.apache.org commented on HIVE-2304:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1700/#review1731
-----------------------------------------------------------



jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
<https://reviews.apache.org/r/1700/#comment3948>

    Please Add a negative testcase that exercises this exception.



jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
<https://reviews.apache.org/r/1700/#comment3947>

    Please add a new testcase or add to an existing testcase instead of modifying a pre-existing
testcase. You have provided test coverage for PreparedStatement.setObject() at the expense
of removing test coverage for PreparedStatement.setBoolean()/setInt(),etc.


- Carl


On 2011-09-02 01:35:33, Carl Steinbach wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1700/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-02 01:35:33)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Review for HIVE-2304 (Ido Hadanny)
bq.  
bq.  
bq.  This addresses bug HIVE-2304.
bq.      https://issues.apache.org/jira/browse/HIVE-2304
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 679792c 
bq.    jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 
bq.  
bq.  Diff: https://reviews.apache.org/r/1700/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Carl
bq.  
bq.



> Support PreparedStatement.setObject
> -----------------------------------
>
>                 Key: HIVE-2304
>                 URL: https://issues.apache.org/jira/browse/HIVE-2304
>             Project: Hive
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 0.7.1
>            Reporter: Ido Hadanny
>            Assignee: Ido Hadanny
>            Priority: Minor
>         Attachments: HIVE-0.8-SetObject.1.patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> PreparedStatement.setObject is important for spring's jdbcTemplate support

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message