Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 10 Aug 2011 23:32:31 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <58121299.25886.1313019151107.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <935272625.25861.1313019036608.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HIVE-2368) Determining whether a Column
 Descriptor is unused may take too long
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082765#comment-13082765 ] 

jiraposter@reviews.apache.org commented on HIVE-2368:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1462/
-----------------------------------------------------------

Review request for hive and Paul Yang.


Summary
-------

To determine if a column descriptor is unused, we call listStorageDescriptorsWithCD(), which may return a big list of SDs. This can severely slow down dropping partitions.

We can add a maximum number of SDs to return, and just ask for 1 SD, since we are just doing an existential check.


This addresses bug HIVE-2368.
    https://issues.apache.org/jira/browse/HIVE-2368


Diffs
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1156401 

Diff: https://reviews.apache.org/r/1462/diff


Testing
-------


Thanks,

Sohan


> Determining whether a Column Descriptor is unused may take too long
> -------------------------------------------------------------------
>
>                 Key: HIVE-2368
>                 URL: https://issues.apache.org/jira/browse/HIVE-2368
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Sohan Jain
>         Attachments: HIVE-2368.1.patch
>
>
> To determine if a column descriptor is unused, we call listStorageDescriptorsWithCD(), which may return a big list of SDs.  This can severely slow down dropping partitions.
> We can add a maximum number of SDs to return, and just ask for 1 SD, since we are just doing an existential check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira