Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0D878240 for ; Mon, 8 Aug 2011 06:53:38 +0000 (UTC) Received: (qmail 25057 invoked by uid 500); 8 Aug 2011 06:53:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 24574 invoked by uid 500); 8 Aug 2011 06:53:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 24502 invoked by uid 99); 8 Aug 2011 06:52:52 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2011 06:52:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 604F81C0282; Mon, 8 Aug 2011 06:52:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6055297918925860372==" MIME-Version: 1.0 Subject: Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases From: "Navis Ryu" To: "Navis Ryu" , "hive" Date: Mon, 08 Aug 2011 06:52:56 -0000 Message-ID: <20110808065256.18572.6310@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1313/ --===============6055297918925860372== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1313/ ----------------------------------------------------------- Review request for hive. Summary ------- If map aggregation is set to false, DISTRIBUTED BY followed by GROUP BY wit= h same key fails in runtime. ReduceSinkDeDuplication optimization should be= avoid if child of child RS is GBY. = This addresses bug HIVE-2329. https://issues.apache.org/jira/browse/HIVE-2329 Diffs ----- ql/src/test/queries/clientpositive/reduce_deduplicate_exclude_gby.q PRE-C= REATION = ql/src/test/results/clientpositive/reduce_deduplicate_exclude_gby.q.out P= RE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.j= ava e91b4d5 = Diff: https://reviews.apache.org/r/1313/diff Testing ------- Thanks, Navis --===============6055297918925860372==--