Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F85F6104 for ; Thu, 4 Aug 2011 21:56:28 +0000 (UTC) Received: (qmail 70361 invoked by uid 500); 4 Aug 2011 21:56:27 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 70249 invoked by uid 500); 4 Aug 2011 21:56:27 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 70232 invoked by uid 99); 4 Aug 2011 21:56:27 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2011 21:56:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AB6351C0049; Thu, 4 Aug 2011 21:56:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9186989785311465501==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2138: Exception when no splits returned from index From: "Syed Albiz" To: "John Sichi" , "Yongqiang He" Date: Thu, 04 Aug 2011 21:56:31 -0000 Message-ID: <20110804215631.21249.68740@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1255/ Cc: "Syed Albiz" ,"hive" In-Reply-To: <20110802234430.1124.60804@reviews.apache.org> References: <20110802234430.1124.60804@reviews.apache.org> --===============9186989785311465501== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1255/ ----------------------------------------------------------- (Updated 2011-08-04 21:56:31.633797) Review request for hive, John Sichi and Yongqiang He. Changes ------- removed stale testcase Summary ------- return an empty array of input splits when we get back no results from the = hiveIndexResult This addresses bug HIVE-2138. https://issues.apache.org/jira/browse/HIVE-2138 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1= a1ecd7 = ql/src/test/queries/clientpositive/index_auto_empty.q PRE-CREATION = ql/src/test/results/clientpositive/index_auto_empty.q.out PRE-CREATION = Diff: https://reviews.apache.org/r/1255/diff Testing ------- added index_auto_test_if_used.q to the test suite Thanks, Syed --===============9186989785311465501==--