Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29C528132 for ; Wed, 10 Aug 2011 23:53:56 +0000 (UTC) Received: (qmail 52062 invoked by uid 500); 10 Aug 2011 23:53:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 52033 invoked by uid 500); 10 Aug 2011 23:53:55 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52023 invoked by uid 500); 10 Aug 2011 23:53:55 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 52017 invoked by uid 99); 10 Aug 2011 23:53:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 23:53:55 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 23:53:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5B12CB6819 for ; Wed, 10 Aug 2011 23:53:29 +0000 (UTC) Date: Wed, 10 Aug 2011 23:53:29 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1098742380.25929.1313020409369.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <507609002.8369.1310063476761.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2272) add TIMESTAMP data type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082772#comment-13082772 ] jiraposter@reviews.apache.org commented on HIVE-2272: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ ----------------------------------------------------------- (Updated 2011-08-10 23:53:23.261081) Review request for hive, Yongqiang He, Ning Zhang, and Siying Dong. Changes ------- -Fix q.out files for timestamp_udf.q and show_functions.q -Incorporate Ashutosh's comments Summary ------- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision YYYY-MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs (updated) ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1156396 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUtcTimestamp.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1156396 trunk/ql/src/test/queries/clientpositive/timestamp_1.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_2.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_3.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_comparison.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_udf.q PRE-CREATION trunk/ql/src/test/results/clientnegative/invalid_create_tbl1.q.out 1156396 trunk/ql/src/test/results/clientnegative/invalid_t_alter1.q.out 1156396 trunk/ql/src/test/results/clientnegative/invalid_t_alter2.q.out 1156396 trunk/ql/src/test/results/clientnegative/invalid_t_create1.q.out 1156396 trunk/ql/src/test/results/clientnegative/invalid_t_create2.q.out 1156396 trunk/ql/src/test/results/clientnegative/invalid_t_transform.q.out 1156396 trunk/ql/src/test/results/clientnegative/wrong_column_type.q.out 1156396 trunk/ql/src/test/results/clientpositive/show_functions.q.out 1156396 trunk/ql/src/test/results/clientpositive/timestamp_1.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/timestamp_2.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/timestamp_3.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/timestamp_comparison.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/timestamp_udf.q.out PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryTimestamp.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 1156396 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableTimestampObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/TimestampObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1156396 Diff: https://reviews.apache.org/r/1135/diff Testing ------- Wrote some unit tests for string/binary serialization. Also ran against test data and looked consistent Thanks, Franklin > add TIMESTAMP data type > ----------------------- > > Key: HIVE-2272 > URL: https://issues.apache.org/jira/browse/HIVE-2272 > Project: Hive > Issue Type: New Feature > Reporter: Franklin Hu > Assignee: Franklin Hu > Fix For: 0.8.0 > > Attachments: hive-2272.1.patch, hive-2272.10.patch, hive-2272.2.patch, hive-2272.3.patch, hive-2272.4.patch, hive-2272.5.patch, hive-2272.6.patch, hive-2272.7.patch, hive-2272.8.patch, hive-2272.9.patch > > > Add TIMESTAMP type to serde2 that supports unix timestamp (1970-01-01 00:00:01 UTC to 2038-01-19 03:14:07 UTC) with optional nanosecond precision using both LazyBinary and LazySimple SerDes. > For LazySimpleSerDe, the data is stored in jdbc compliant java.sql.Timestamp parsable strings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira