hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2272) add TIMESTAMP data type
Date Wed, 10 Aug 2011 21:31:28 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082694#comment-13082694
] 

jiraposter@reviews.apache.org commented on HIVE-2272:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1135/#review1391
-----------------------------------------------------------



trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
<https://reviews.apache.org/r/1135/#comment3175>

    Parameterize the WritableComparable there to eliminate warning.



trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
<https://reviews.apache.org/r/1135/#comment3172>

    Do we really need two booleans? It seems at a time data will be either in byte[] or in
timestamp, so one bool will suffice?



trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
<https://reviews.apache.org/r/1135/#comment3174>

    Arrays.fill() might be better here.



trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
<https://reviews.apache.org/r/1135/#comment3173>

    I think you want Arrays.equals() there.



trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
<https://reviews.apache.org/r/1135/#comment3177>

    System.arrayCopy() will be more efficient here.



trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java
<https://reviews.apache.org/r/1135/#comment3178>

    System.arrayCopy() will be more efficient here.


- Ashutosh


On 2011-08-08 18:19:27, Franklin Hu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1135/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-08 18:19:27)
bq.  
bq.  
bq.  Review request for hive, Yongqiang He, Ning Zhang, and Siying Dong.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization.
bq.  Supports SQL style jdbc timestamps of the format with nanosecond precision
bq.  YYYY-MM-DD HH:MM:SS[.fff...]
bq.  
bq.  
bq.  This addresses bug HIVE-2272.
bq.      https://issues.apache.org/jira/browse/HIVE-2272
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java
1155026 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1155026

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java
PRE-CREATION 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION

bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUtcTimestamp.java
PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1155026 
bq.    trunk/ql/src/test/queries/clientpositive/timestamp_1.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/timestamp_2.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/timestamp_3.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/timestamp_comparison.q PRE-CREATION 
bq.    trunk/ql/src/test/queries/clientpositive/timestamp_udf.q PRE-CREATION 
bq.    trunk/ql/src/test/results/clientnegative/invalid_create_tbl1.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/invalid_t_alter1.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/invalid_t_alter2.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/invalid_t_create1.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/invalid_t_create2.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/invalid_t_transform.q.out 1155026 
bq.    trunk/ql/src/test/results/clientnegative/wrong_column_type.q.out 1155026 
bq.    trunk/ql/src/test/results/clientpositive/show_functions.q.out 1155026 
bq.    trunk/ql/src/test/results/clientpositive/timestamp_1.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/timestamp_2.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/timestamp_3.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/timestamp_comparison.q.out PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/timestamp_udf.q.out PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java PRE-CREATION

bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java PRE-CREATION

bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryTimestamp.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampObjectInspector.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
1155026 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableTimestampObjectInspector.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/TimestampObjectInspector.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampObjectInspector.java
PRE-CREATION 
bq.    trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1155026

bq.  
bq.  Diff: https://reviews.apache.org/r/1135/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Wrote some unit tests for string/binary serialization. Also ran against test data and
looked consistent
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Franklin
bq.  
bq.



> add TIMESTAMP data type
> -----------------------
>
>                 Key: HIVE-2272
>                 URL: https://issues.apache.org/jira/browse/HIVE-2272
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2272.1.patch, hive-2272.10.patch, hive-2272.2.patch, hive-2272.3.patch,
hive-2272.4.patch, hive-2272.5.patch, hive-2272.6.patch, hive-2272.7.patch, hive-2272.8.patch,
hive-2272.9.patch
>
>
> Add TIMESTAMP type to serde2 that supports unix timestamp (1970-01-01 00:00:01 UTC to
2038-01-19 03:14:07 UTC) with optional nanosecond precision using both LazyBinary and LazySimple
SerDes. 
> For LazySimpleSerDe, the data is stored in jdbc compliant java.sql.Timestamp parsable
strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message