hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2346) Add hooks to run when execution fails.
Date Tue, 09 Aug 2011 23:45:29 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081998#comment-13081998
] 

jiraposter@reviews.apache.org commented on HIVE-2346:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1295/
-----------------------------------------------------------

(Updated 2011-08-09 23:44:00.972625)


Review request for hive and Ning Zhang.


Changes
-------

Added the hive.exec.failure.hooks property to hive-default.xml


Summary
-------

I added a new type of hook, which will be run when a job fails.


This addresses bug HIVE-2346.
    https://issues.apache.org/jira/browse/HIVE-2346


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155569 
  trunk/conf/hive-default.xml 1155569 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155569 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 1155569 

Diff: https://reviews.apache.org/r/1295/diff


Testing
-------

I ran the TestCliDriver and TestNegativeCliDriver test suites and verified they passed.

In addition, I created a sample hook, which simply logged that it was run.  I verified it
was run on a failure, but not when a job succeeded.


Thanks,

Kevin



> Add hooks to run when execution fails.
> --------------------------------------
>
>                 Key: HIVE-2346
>                 URL: https://issues.apache.org/jira/browse/HIVE-2346
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2346.1.patch.txt, HIVE-2346.2.patch.txt, HIVE-2346.3.patch.txt
>
>
> Currently, when a query fails, the Post Execution Hooks are not run.
> Adding hooks to be run when a query fails could allow for better logging etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message