hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2196) Ensure HiveConf includes all properties defined in hive-default.xml
Date Mon, 15 Aug 2011 02:34:28 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084944#comment-13084944
] 

jiraposter@reviews.apache.org commented on HIVE-2196:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1423/#review1451
-----------------------------------------------------------


bq. > The below configurations are not used in the code base but these configurations are
required for the system so need to maintain in the hive-default.xml and no need to add in
the HiveConf.java

Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa.

- Carl


On 2011-08-09 19:11:13, chinna wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1423/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-09 19:11:13)
bq.  
bq.  
bq.  Review request for hive, Carl Steinbach and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The below configurations are not used in the code base so removed from the hive-default.xml
bq.  
bq.  hive.mapjoin.hashtable.initialCapacity 
bq.  hive.mapjoin.hashtable.loadfactor 
bq.  hive.mapjoin.smalltable.filesize 
bq.  hive.optimize.pruner 
bq.  hive.stats.jdbc.atomic 
bq.  hive.concurrency.manager 
bq.  
bq.  The below configurations are not used in the code base but these configurations are required
for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java
bq.  
bq.  javax.jdo.option.ConnectionDriverName 
bq.  javax.jdo.PersistenceManagerFactoryClass 
bq.  javax.jdo.option.DetachAllOnCommit 
bq.  javax.jdo.option.NonTransactionalRead 
bq.  javax.jdo.option.ConnectionUserName 
bq.  fs.har.impl 
bq.  
bq.  
bq.  This addresses bug HIVE-2196.
bq.      https://issues.apache.org/jira/browse/HIVE-2196
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275 
bq.    trunk/conf/hive-default.xml 1155275 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1155275 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java
1155275 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
1155275 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
1155275 
bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java
1155275 
bq.    trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java
1155275 
bq.    trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275

bq.  
bq.  Diff: https://reviews.apache.org/r/1423/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All unit tests passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  chinna
bq.  
bq.



> Ensure HiveConf includes all properties defined in hive-default.xml
> -------------------------------------------------------------------
>
>                 Key: HIVE-2196
>                 URL: https://issues.apache.org/jira/browse/HIVE-2196
>             Project: Hive
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: Carl Steinbach
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2196.1.patch, HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message