hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Chen" <charlesc...@fb.com>
Subject Re: Review Request: HIVE-1953: Hive should process comments in CliDriver
Date Fri, 19 Aug 2011 21:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/#review1564
-----------------------------------------------------------


Currently if you type something like

EXPLAIN SELECT "abcd
--
efgh" as field from invites;

the string "abcd\n--\nefgh"with the newlines is accepted--this diff removes the line with
the "--" which seems incorrect.

- Charles


On 2011-08-19 08:10:32, Syed Albiz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1587/
> -----------------------------------------------------------
> 
> (Updated 2011-08-19 08:10:32)
> 
> 
> Review request for hive and Yongqiang He.
> 
> 
> Summary
> -------
> 
> skip comments in cliDriver.main() instead of passing down to command processors.
> 
> 
> This addresses bug HIVE-1953.
>     https://issues.apache.org/jira/browse/HIVE-1953
> 
> 
> Diffs
> -----
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5 
> 
> Diff: https://reviews.apache.org/r/1587/diff
> 
> 
> Testing
> -------
> 
> tested build, since the test suite goes through driver, adding a query file test case
did not work.
> 
> 
> Thanks,
> 
> Syed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message