hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinna...@huawei.com
Subject Re: Review Request: Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
Date Wed, 17 Aug 2011 13:29:30 GMT


> On 2011-07-18 20:45:26, John Sichi wrote:
> > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java,
line 267
> > <https://reviews.apache.org/r/1088/diff/1/?file=22380#file22380line267>
> >
> >     We should get rid of the member variable standAloneClient too since it is part
of the dead code.
> >     
> >     Now that we'll start calling shutdown (which we were skipping before), what
will be the effect?
> >

1) standAloneClient this variable is removed. 

2) As of now metaStoreClient.close() is not executing client.shutdown() because of this fix
it will close  the objectStore. After closing if any get request it will create new objectStore.


- chinna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/#review1099
-----------------------------------------------------------


On 2011-07-12 14:06:28, chinna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1088/
> -----------------------------------------------------------
> 
> (Updated 2011-07-12 14:06:28)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> 
> 
> This addresses bug HIVE-2184.
>     https://issues.apache.org/jira/browse/HIVE-2184
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1144190 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190 
> 
> Diff: https://reviews.apache.org/r/1088/diff
> 
> 
> Testing
> -------
> 
> Ran all the testcases
> 
> 
> Thanks,
> 
> chinna
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message