hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <>
Subject Review Request: Warn user that precision is lost when bigint is implicitly cast to double.
Date Mon, 15 Aug 2011 23:37:16 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hive and Siying Dong.


I added a check in the code for equality expressions (includes inequalities) with operands
of different types, that throws an error or logs a warning, depending on strict mode, if one
operand is a string or double and the other is a bigint.

This addresses bug HIVE-2378.


  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ 1157946 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ 1157946

  trunk/ql/src/test/queries/clientnegative/compare_double_bigint.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/compare_string_bigint.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/compare_double_bigint.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/compare_string_bigint.q.out PRE-CREATION 



I added two tests (one for strings and one for doubles) to record the issue.

I also verified the unit tests still run.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message