hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sam...@fb.com
Subject Re: Review Request: HIVE-1916: Change Default Alias For Aggregated Columns (_c1)
Date Mon, 15 Aug 2011 20:09:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1441/
-----------------------------------------------------------

(Updated 2011-08-15 20:09:08.444993)


Review request for hive and Ning Zhang.


Changes
-------

Using "columnalias" instead of "columnname" to be consistent with description and code intent.
e.g. Hive params are now called "hive.autogen.columnalias.*" instead of "hive.autogen.columnname."
Fixing style issues.
Updated unit test query script with more select expressions including newlines and tabs.


Summary
-------

Default behavior will be as before.
Adding new Hive conf vars to make the column names include the aggregation function and params.


This addresses bug HIVE-1916.
    https://issues.apache.org/jira/browse/HIVE-1916


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1157970 
  trunk/conf/hive-default.xml 1157970 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1157970 
  trunk/ql/src/test/queries/clientpositive/autogen_colalias.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/autogen_colalias.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1441/diff


Testing
-------

Added new query file with expected results. All unit tests pass


Thanks,

sameerm


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message