hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <>
Subject Re: Review Request: Make performance logging configurable.
Date Sun, 14 Aug 2011 00:54:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-08-14 00:54:16.595577)

Review request for hive and Ning Zhang.


Updated patch.


I created a new class PerfLogger, which wraps the old functionality of Utilities' PerfLogBegin
and PerfLogBegin methods.  I also added a config variable hive.exec.perf.logger.  The value
of this variable can be changed to point to a subclass of PerfLogger which can customize the
code in PerfLogBegin and PerfLogEnd.

This addresses bug HIVE-2364.

Diffs (updated)

  trunk/common/src/java/org/apache/hadoop/hive/conf/ 1157444 
  trunk/conf/hive-default.xml 1157444 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/ 1157444 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ 1157444 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/log/ PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/ 1157444 



I ran the code as it is and made sure it continued to log the performance messages as before.

I also created a subclass of PerfLogger and used its class name as the value of hive.exec.perf.logger,
and verified the subclass's code was run.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message