hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ning Zhang" <nzh...@fb.com>
Subject Re: Review Request: HIVE-1916: Change Default Alias For Aggregated Columns (_c1)
Date Fri, 12 Aug 2011 17:46:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1441/#review1424
-----------------------------------------------------------



trunk/conf/hive-default.xml
<https://reviews.apache.org/r/1441/#comment3286>

    change "aggregate function" to "function" to avoid confusion. 



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3288>

    styling nitpick: space between '='



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3287>

    remove the trailing space. 



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3289>

    remove trailing space



trunk/ql/src/test/queries/clientpositive/autogen_colname.q
<https://reviews.apache.org/r/1441/#comment3290>

    in this test case can you add more functions such as '%', '/' and even '\n'? I think the
parser should already removed '\n' or TABs but need to confirm in the unit test. 


- Ning


On 2011-08-10 00:56:44, sameerm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1441/
> -----------------------------------------------------------
> 
> (Updated 2011-08-10 00:56:44)
> 
> 
> Review request for hive and Ning Zhang.
> 
> 
> Summary
> -------
> 
> Default behavior will be as before.
> Adding new Hive conf vars to make the column names include the aggregation function and
params.
> 
> 
> This addresses bug HIVE-1916.
>     https://issues.apache.org/jira/browse/HIVE-1916
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155181 
>   trunk/conf/hive-default.xml 1155181 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1155181 
>   trunk/ql/src/test/queries/clientpositive/autogen_colname.q PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/autogen_colname.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1441/diff
> 
> 
> Testing
> -------
> 
> Added new query file with expected results. All unit tests pass
> 
> 
> Thanks,
> 
> sameerm
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message