hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <kevinwilf...@fb.com>
Subject Review Request: sample_islocalmode_hook.q test is non-deterministic
Date Fri, 12 Aug 2011 00:17:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1477/
-----------------------------------------------------------

Review request for hive and Siying Dong.


Summary
-------

Adding order by to the two queries used to create the test tables makes the test deterministic.


This addresses bug HIVE-2371.
    https://issues.apache.org/jira/browse/HIVE-2371


Diffs
-----

  trunk/ql/src/test/queries/clientpositive/sample_islocalmode_hook.q 1156861 
  trunk/ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 1156861 

Diff: https://reviews.apache.org/r/1477/diff


Testing
-------

I ran the test and verified it passed.

I also had a person who had been seeing the test fail do to non-determinism run the test and
verify that it passed.


Thanks,

Kevin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message